some typing advice #508
Open
some typing advice #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change space dismatching btween 4 spaces and 2 spaces, also move yes and no outside code blocks so matching with line225
|
And there are some more confusing usage of two spaces and four spaces in python examples. |
line671 should be 2.9.1
|
line671 should be 2.9.1 |
it would be better if change 'yield' into inline code style
|
also at line799, it would be better with yes: and no: |
crypt096
approved these changes
Nov 10, 2021
tkohli
approved these changes
Apr 24, 2022
ProKashif
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change space dismatching btween 4 spaces and 2 spaces,
also move yes and no outside code blocks so matching with line225