chore: add jdk 8 verification to showcase CI #3735
Conversation
|
Adding |
product-auto-label
bot
added
size: m
.github/workflows/ci.yaml
Outdated
| java-version: 8 | ||
| distribution: temurin | ||
| - run: java -version | ||
| - name: Showcase golden tests |
There was a problem hiding this comment.
The golden tests verify the static generation results, which would not change with Java 8.
There was a problem hiding this comment.
Ah that's a good point, thank you
| - name: Parse showcase version | ||
| working-directory: java-showcase/gapic-showcase | ||
| run: echo "SHOWCASE_VERSION=$(mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout)" >> "$GITHUB_ENV" | ||
| - name: Install showcase server |
There was a problem hiding this comment.
Downloading showcase server should ideally only happen once, but I guess that may require this to be merged with the regular showcase tests. Is there a way for two CI jobs to share the same set up?
There was a problem hiding this comment.
Hm true, from looking at the logs, I think this step gets repeated even when we have a matrix. Haven't tried this out yet but we could have a separate job that does the download once and caches the showcase path. All the other showcase jobs would be dependent on this job. wdyt?
However, this may lead to the "download" job showing on the CI.
|
|
This PR adds showcase testing for JDK 8.
According to https://logback.qos.ch/dependencies.html 1.5.x targets at least JDK 11.