Skip to content

feat: Handle JSON-like structured logs better #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from

Conversation

dhable
Copy link

@dhable dhable commented Apr 18, 2025

Updates the OTEL pipeline to handle structured logs better. If the body content is an OTEL map, it will merge the body map into the log attributes map. If the body is a JSON object, it will parse the JSON string into an OTEL map, then merge the fields into the log attributes map.

Replacing the Body field doesn't work since the Clickhouse exporter schema defines Body as string, so any parsed out object ends up turning back into a string. At least as log resources, it's a lighter weight means of grouping and filtering in the UI.

Ref: HDX-1453

Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: 6d16148

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ❌ Failed (Inspect) Apr 21, 2025 5:54pm

@dhable dhable force-pushed the dan/hdx-1453-v2-auto-parse-json-ingestion branch from e0a2d33 to cae08a6 Compare April 18, 2025 19:57
@dhable dhable marked this pull request as ready for review April 18, 2025 19:57
Updates the OTEL pipeline to handle structured logs better. If the body
content is an OTEL map, it will merge the body map into the log attributes
map. If the body is a JSON object, it will parse the JSON string into an
OTEL map, then merge the fields into the log attributes map.

Replacing the Body field doesn't work since the Clickhouse exporter schema
defines Body as string, so any parsed out object ends up turning back into
a string. At least as log resources, it's a lighter weight means of grouping
and filtering in the UI.

Ref: HDX-1453
@dhable dhable force-pushed the dan/hdx-1453-v2-auto-parse-json-ingestion branch from cae08a6 to 529253e Compare April 18, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant