-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Feat: Adds OpenSearch2.19.1 as the vector_database support #7140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the contribution. OpenSearch can be added as a doc engine alternative. However, maintaining OpenSearch is not an easy work, after this PR is merged, OpenSearch might not be able to work after several weeks. |
docker/.env
Outdated
@@ -2,7 +2,8 @@ | |||
# Available options: | |||
# - `elasticsearch` (default) | |||
# - `infinity` (https://github.com/infiniflow/infinity) | |||
DOC_ENGINE=${DOC_ENGINE:-elasticsearch} | |||
# - `opensearch` (https://github.com/opensearch-project/OpenSearch) | |||
DOC_ENGINE=${DOC_ENGINE:-opensearch} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default DOC_ENGINE should be elasticsearch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asiroliu I'v changed it into elasticsearch by default in my commit. It's a config mistake I forgot to change back from my local environment
Thanks for you reply, and I'v changed some litte problems mentioned above. I am an search-engine engineer focusing on the stuff about OpenSearch/Elasticsearch for years, and also write some plugins for Opnsearch.I will still pay much attention on ES/OS continuously. During these two years, We gave more attention on RAG stuff |
@asiroliu @yingfeng @KevinHuSh ,hi: I've made some commits mainly about fomat and comment. Please review again, thanks a lot |
It can not pass CI, the container of elasticsearch can not be started. See the CI logs https://github.com/infiniflow/ragflow/actions/runs/14533575135/job/40777952188 |
It worked well now at my local environment, I will check the code again and create a virtual machine to verify it. Have a nice weekend |
Still the same error for CI:
|
00d0b0d
to
c6f9337
Compare
### What problem does this PR solve? Documentation for MCP server ### Type of change - [x] Documentation Update --------- Co-authored-by: writinwaters <[email protected]>
Add MCP support with a client example. Issue link: infiniflow#4344 - [x] New Feature (non-breaking change which adds functionality)
Add MCP support with a client example. Issue link: infiniflow#4344 - [x] New Feature (non-breaking change which adds functionality)
Add MCP support with a client example. Issue link: infiniflow#4344 - [x] New Feature (non-breaking change which adds functionality)
hi,there were some config adaption mistakes before . I reckeced on my new environment both on ES and OpenSearch . I've repushed today and I see the ci has passed |
Shouldn't tests to OpenSearch be added here: https://github.com/infiniflow/ragflow/blob/main/.github/workflows/tests.yml ? |
@pyyuhao |
Thanks for your review. |
What problem does this PR solve?
This PR adds the support for latest OpenSearch2.19.1 as the store engine & search engine option for RAGFlow.
Main Benefit
Changes
How to use
Others
Our team tested a lot of docs in our environment by using OpenSearch as the vector database ,it works very well.
All the conifg for OpenSearch is necessary.
Type of change