Default singleClickNavigation back to false

[jtpio]

Fixes #7538

See #7538 for more context.

• Update default value for singleClickNavigation
• Mention in the user facing changelog

[github-actions]

👈 Launch a Binder on branch jtpio/notebook/single-click-navigation-default

[brichet]

Thanks @jtpio, looks good

[afshin]

I wonder if moving the single click handling from mousedown to click would fix the underlying problem.

diff --git a/packages/filebrowser/src/listing.ts b/packages/filebrowser/src/listing.ts
index 9a63d85329..2b0d377d58 100644
--- a/packages/filebrowser/src/listing.ts
+++ b/packages/filebrowser/src/listing.ts
@@ -1376,6 +1376,10 @@ export class DirListing extends Widget {
       //    previously focussed item will be focussed.
       this._focusItem(this._focusIndex);
     }
+
+    if (this._allowSingleClick) {
+      this.evtDblClick(event as MouseEvent);
+    }
   }

   /**
@@ -1470,10 +1474,6 @@ export class DirListing extends Widget {
       document.addEventListener('mouseup', this, true);
       document.addEventListener('mousemove', this, true);
     }
-
-    if (this._allowSingleClick) {
-      this.evtDblClick(event as MouseEvent);
-    }
   }

   /**

[jtpio]

We discussed this PR in the Jupyter Frontends call today, trying to weigh the pros and cons for changing the default.

While changing the default back to double click would solve the issue, it would also be a change of behavior in 7.4, for a default that was added in 7.3. So there is a risk of making Notebook users annoyed by these changes of default between minor releases, with a short notice.

Also, it sounded like this is actually a bug, that could be fixed as a regular bug fix. It's not clear yet whether that would mean fixing it in JupyterLab or Notebook, but at least it could be released as 7.4.x.

So closing this PR for now to unblock the 7.4.0 release. Since the bug has been in 7.3.x, we could fix it as part of 7.4.x.

[jtpio]

I wonder if moving the single click handling from mousedown to click would fix the underlying problem.

Ah interesting, thanks @afshin for looking into this 👍

I can try to add the patch in a draft PR here in notebook to see if it helps.