-
Notifications
You must be signed in to change notification settings - Fork 33
New block custom iops ranges added and test cases updated #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New block custom iops ranges added and test cases updated #203
Conversation
Signed-off-by: Meetanshi-Gupta <[email protected]>
Hi @MeetanshiGupta. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add MaximumBlockVolumeDiskSizeInGb in driver constants. Let remove dependancy on ibm-csi-common
/ok-to-test |
…iskSizeInGb created and referenced Signed-off-by: Meetanshi-Gupta <[email protected]>
@MeetanshiGupta Please remove changes from vendor dir. Also can you fix the failed tests |
Signed-off-by: Meetanshi-Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Changes looks good , please post the results with volume storage class secret for each new range then we should be good
Also do few negative cases and error should be in format
invalid IOPS: <%v> for capacity: <%vGiB>. Should be in range [%d - %d]",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeetanshiGupta , Can you upload the test results
With Block add-on and without Secret
|
With Block add-on and with Secret
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeetanshiGupta , lets make it uniform between storage class and storage class secret, may be batter to remove validation check
Signed-off-by: Meetanshi-Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the test cases , remove the validation for iops from the test cases from TestOverrideParams
{
testCaseName: "Secret invalid IOPS for custom class",
request: &csi.CreateVolumeRequest{Name: volumeName, CapacityRange: &csi.CapacityRange{RequiredBytes: 11811160064, LimitBytes: utils.MinimumVolumeSizeInBytes + utils.MinimumVolumeSizeInBytes},
Parameters: map[string]string{Profile: "custom",
Zone: "testzone",
Region: "us-south-test",
Tag: "test",
ResourceGroup: "myresourcegroups",
Encrypted: "false",
EncryptionKey: "123",
IOPS: noIops,
},
Secrets: map[string]string{
IOPS: secretInvalidIops,
},
},
expectedVolume: &provider.Volume{Name: &volumeName,
Capacity: &volumeSize,
VPCVolume: provider.VPCVolume{Profile: &provider.Profile{Name: "custom"}},
},
expectedStatus: false,
expectedError: fmt.Errorf("%v:<%v> invalid value", IOPS, secretInvalidIops),
},
Signed-off-by: Meetanshi-Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Testing of negative test cases via secret
|
Testing of positive test cases via secret
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
please verify before releasing it
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arahamad, MeetanshiGupta, sameshai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New block custom iops ranges added, test cases updated and MaximumBlockVolumeDiskSizeInGb variable added.
GHE Issue - https://github.ibm.com/alchemy-containers/armada-storage/issues/6768