Enable unprefixed label setting via feature gate

[fmuyassarov]

Currently, unprefixed labels are not allowed, despite the existence of the DisableAutoPrefix feature gate, which is intended for this purpose. This change ensures that when DisableAutoPrefix is set to True, the namespace addition is skipped, allowing unprefixed labels.
Fixes: #2074

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	881642e
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67ed80ab6a44e80008b080af
😎 Deploy Preview	https://deploy-preview-2114--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[fmuyassarov]

/cc @marquiz

[marquiz]

Thank you @fmuyassarov for working on this 🙏 Would it be possible to add some testing for this. E.g. in e2e tests enable feature gate in some test and check that unprefixed label gets created or smth?

[fmuyassarov]

Thank you @fmuyassarov for working on this 🙏 Would it be possible to add some testing for this. E.g. in e2e tests enable feature gate in some test and check that unprefixed label gets created or smth?

Absolutely!

[Copilot]

Pull Request Overview

This PR enables unprefixed labels when the DisableAutoPrefix feature gate is set to true, bypassing the namespace addition for such labels.

• Adjusts error handling in filterFeatureLabel to allow unprefixed labels when the feature gate is enabled.
• Updates documentation to clarify the behavior of label prefixing with and without the feature gate.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/nfd-master/nfd-master.go	Refactored error handling in filterFeatureLabel to bypass errors for unprefixed labels when the feature gate is enabled.
docs/reference/feature-gates.md	Updated the description of label prefixing behavior to align with the new feature gate functionality.

Comments suppressed due to low confidence (1)

pkg/nfd-master/nfd-master.go:506

• [nitpick] The compound conditional here could be refactored for better clarity; consider assigning sub-conditions to well-named variables or adding inline comments to explain the logic of bypassing the error when the feature gate is enabled.

if !nfdfeatures.NFDFeatureGate.Enabled(nfdfeatures.DisableAutoPrefix) || err != validate.ErrUnprefixedKeysNotAllowed {

[ArangoGutierrez]

Thank you @fmuyassarov for working on this 🙏 Would it be possible to add some testing for this. E.g. in e2e tests enable feature gate in some test and check that unprefixed label gets created or smth?

LGTM will come after testing. PR looks good

[marquiz]

Thank you @fmuyassarov for this PR.

I think that a similar treatment for annotations and extended resources, for consistency 🧐

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fmuyassarov]

Thank you @fmuyassarov for this PR.

I think that a similar treatment for annotations and extended resources, for consistency 🧐

Sure, will do that.

[fmuyassarov]

ping @ArangoGutierrez

[marquiz]

ping @ArangoGutierrez