Skip to content

Create separate configuration for extended integration tests. #34708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create separate configuration for extended integration tests. #34708

wants to merge 1 commit into from
+97 −23

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Apr 23, 2025 •
edited
Loading

Create separate configuration for extended integration tests.

Sometimes we miss testing the slow and redundant integration tests before merging to main, which results in errors in periodic tests. This happens because the presubmit integration tests are filtered by the INTEGRATION_RUN_ALL flag.

To prevent this, I propose running the extended tests in parallel with the required tests instead of skipping it in presubmit tests. As for the multikueue integration tests, we can run all of them – they only take 6m24s.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and mimowo April 23, 2025 07:52
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mbobrovskyi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 23, 2025
@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo @tenzen-y

@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y April 23, 2025 07:52
@mbobrovskyi
Copy link
Contributor Author

/hold for kubernetes-sigs/kueue#5068.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2025
@mbobrovskyi mbobrovskyi mentioned this pull request Apr 24, 2025
Merged
@mbobrovskyi mbobrovskyi force-pushed the kueue/test-integration-slow-and-redundant branch from 45209ae to 8302e02 Compare April 24, 2025 11:40
@mbobrovskyi mbobrovskyi changed the title Create separate configuration for slow and redundant integration tests. Create separate configuration for baseline and extended integration tests. Apr 24, 2025
@mbobrovskyi mbobrovskyi force-pushed the kueue/test-integration-slow-and-redundant branch from 8302e02 to 0766c2b Compare April 24, 2025 11:42
@mbobrovskyi mbobrovskyi changed the title Create separate configuration for baseline and extended integration tests. Create separate configuration for extended integration tests. Apr 24, 2025
@mimowo
Copy link
Contributor

mimowo commented Apr 24, 2025

/ok-to-test

/hold for kubernetes-sigs/kueue#5068.

@mbobrovskyi is it ready now?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbobrovskyi @k8s-ci-robot @mimowo