Allow login and registration with capitalized emails #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rattone
reviewed
Apr 13, 2025
|
|
||
| // Here we will attempt to reset the user's password. If it is successful we | ||
| // will update the password on an actual user model and persist it to the | ||
| // database. Otherwise we will parse the error and return the response. | ||
| $status = Password::reset( | ||
| $this->only('email', 'password', 'password_confirmation', 'token'), | ||
| $this->only($validated['email'], 'password', 'password_confirmation', 'token'), |
There was a problem hiding this comment.
only() method accept input names not values
There was a problem hiding this comment.
Thanks @Rattone, yes, @cspohn-ltb, can you make this update.
|
@cspohn-ltb, if you make that update in the This is more of the 'Laravel' way 😉 Thanks, after you make those updates I can get this approved and we can work on merging it in. |
|
@tnylea I've adjusted the changes as requested and included some additional unit tests 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for users to register and log in using email addresses with capital letters (e.g. [email protected]). Internally, all email addresses are automatically converted to lowercase to ensure consistent handling and avoid duplicate accounts due to case differences.
What’s changed:
During registration, the provided email is converted to lowercase before being saved.
During login, the input email is also lowercased before attempting authentication.
Improves user experience and reduces confusion related to email case sensitivity.
This update is fully backward-compatible and does not affect existing accounts.