Skip to content

fx: _reasoning flag used to set api params #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 22, 2025
Merged

fx: _reasoning flag used to set api params #139

merged 6 commits into from
Apr 22, 2025

Conversation

Pythonista7
Copy link
Contributor

Changes

  • re-evaluate _reasoning flag after model selection inside generate()

Issue

This resolves #138

@Pythonista7 Pythonista7 mentioned this pull request Apr 22, 2025
Closed
saqadri
saqadri approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@saqadri saqadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Pythonista7!

@saqadri saqadri merged commit c9154d7 into lastmile-ai:main Apr 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saqadri saqadri saqadri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with model selection with openai reasoning models
2 participants
@Pythonista7 @saqadri