feat: add persistent browser context handling #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add _persistentContext property to store and reuse browser context - Cache and reuse existing persistent context if available - Improve browser context management efficiency
src/context.ts
Outdated
| private async _launchPersistentContext(): Promise<playwright.BrowserContext> { | ||
| // If we already have a persistent context, return it. | ||
| if (this._persistentContext) { |
There was a problem hiding this comment.
It should be higher up, in _ensureBrowserContext
There was a problem hiding this comment.
you're right, made the required changes and pushing another commit into the PR
- Consolidate persistent context handling into _ensureBrowserContext - Optimize cleanup by running context/browser closures in parallel - Only set persistent context for local browser instances - Move _persistentContext property with other context properties This change simplifies the browser context management code while maintaining the same functionality, making it more maintainable and efficient.
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to create a ProcessSingleton for your profile directory