feat(html): allow setting a title to display #35659
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Apr 18, 2025
This comment has been minimized.
This comment has been minimized.
| projectNames={report?.json().projectNames || []} | ||
| /> | ||
| <Body> | ||
| <TestFilesHeader report={json} filteredStats={filteredStats} metadataVisible={metadataVisible} toggleMetadataVisible={() => setMetadataVisible(visible => !visible)}/> |
There was a problem hiding this comment.
Why is everything changes?
| @@ -55,7 +55,7 @@ export const TestCaseView: React.FC<{ | |||
| <div style={{ width: 10 }}></div> | |||
| <div className={clsx(!next && 'hidden')}><Link href={testResultHref({ test: next }) + filterParam}>next »</Link></div> | |||
| </div>} | |||
| {test && <div className='test-case-title'>{test?.title}</div>} | |||
| {test && <div className='report-title'>{test?.title}</div>} | |||
There was a problem hiding this comment.
We should have it with a neutral name in the common.css
| @@ -83,6 +84,9 @@ export const TestFilesHeader: React.FC<{ | |||
| <div data-testid='overall-duration' style={{ color: 'var(--color-fg-subtle)' }}>Total time: {msToString(report.duration ?? 0)}</div> | |||
| </div> | |||
| {metadataVisible && <MetadataView metadata={report.metadata}/>} | |||
| {report.options.title && <div className={clsx('report-title', metadataVisible && 'metadata-visible')}> | |||
There was a problem hiding this comment.
Let's make sure the titles is above the metadata.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 failed 5 flaky39054 passed, 799 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to display a title in the HTML reporter. It is configured through the main Playwright config:
or via the envvar
PLAYWRIGHT_HTML_TITLE.Titles are displayed solely on the root page of the reporter, in the same manner as we display test titles.
The document title is also set to this configured value, if set.
Addresses #35614.