utils: Add a fail-safe that will add the last reported Azure sub ID to properties #1977
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+240
to
+246
| if (context.telemetry.properties.subscriptionId) { | ||
| // set the lastReported subscription id to the current one if it exists | ||
| ext._internalReporter.lastReportedAzureSubscriptionId = context.telemetry.properties.subscriptionId; | ||
| } else { | ||
| // use the last reported subscription id if no subscription id was set on the telemetry properties | ||
| context.telemetry.properties.subscriptionId = ext._internalReporter.lastReportedAzureSubscriptionId; | ||
| } |
There was a problem hiding this comment.
This seems like something that is better solved at the time of Kusto querying, rather than this. Failing that, I'd try to create a telemetry handler to do this if possible:
vscode-azuretools/utils/src/callWithTelemetryAndErrorHandling.ts
Lines 97 to 99 in 39c8500
|
Talked about this with Brandon offline and am closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a property to the internal telemetry reporter that will save the last reported Azure sub ID. I think it's safe to do this, even for commands that don't directly interact with Azure, because we're more interested in users that are engaged/signed in Azure even if they happened to do a local command (such as create a new project).