[stdlib] Add Error.as_string_slice() and polish
#4304
Conversation
| ), | ||
| ")", | ||
| ) | ||
| return String("Error(", repr(self.as_string_slice()), ")") |
There was a problem hiding this comment.
Is the repr necessary (can we make it "Error('" etc.)?
There was a problem hiding this comment.
I also don't like building a String unnecessarily, but I don't know whether to remove this. It adds " to the end and beginning of the message or ' if the message contains ", it also encodes control characters in the ASCII range. Since it encodes those characters instead of printing, I think it's worth it in cases where you would want to print something that might have been corrupted on the way. But I'm not sure.
There was a problem hiding this comment.
I see. Maybe we should make repr return a different Writable than String in the future.
There was a problem hiding this comment.
Maybe once we have some API for streaming a repr i.e. __repr__(self, mut writer: Writer)
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
martinvuyk
force-pushed
the
add-error-as-stringslice
branch
from
92a9cad to
b97aded
Compare
Add
Error.as_string_slice()and polish