feat: Option to Ignore window.origin
#290
Open
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case that I need to run the remote in dev mode but keep attaching it to the host.
This original line
const origin = window ? window.origin : "//${host}:${viteConfig.server?.port}"
prevents me from using the remote this way, because it tries to load the remote from the host url.
Adding this new parameter makes it possible to do this use case and keep the original behavior.