feat: add async device ID retrieval COMPASS-8443 #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
force-pushed
the
gagik/async-native-device-id
branch
3 times, most recently
from
ce813e5 to
ced5070
Compare
gagik
force-pushed
the
gagik/async-native-device-id
branch
2 times, most recently
from
2d62989 to
a131a3a
Compare
gagik
force-pushed
the
gagik/docs-machine-id
branch
from
ea81a60 to
dfa9669
Compare
We'd need to retrieve the device ID asynchronously to avoid blocking the main thread for this so this adds asynchronous worker code
gagik
force-pushed
the
gagik/async-native-device-id
branch
from
a131a3a to
b89cbb8
Compare
gagik
force-pushed
the
gagik/async-native-device-id
branch
from
b89cbb8 to
7b98d48
Compare
gagik
force-pushed
the
gagik/async-native-device-id
branch
from
ace884f to
bf09b50
Compare
gagik
force-pushed
the
gagik/async-native-device-id
branch
from
bf09b50 to
2b22c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd need to retrieve the device ID asynchronously to avoid blocking the main thread for this so this adds an asynchronous implementation and more tests.