(EAI-923) universal tagging system #671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodben
reviewed
Apr 10, 2025
| /** | ||
| All possible MongoDB tags as enum. | ||
| */ | ||
| export const mongoDbTags = { |
There was a problem hiding this comment.
i'm confused by this. isn't this a record, not an enum?
There was a problem hiding this comment.
typescript does support enums as a firstclass construct https://www.w3schools.com/typescript/typescript_enums.php
consider also doing a Set
There was a problem hiding this comment.
You're right, its not an enum. I made some changes that simplify it a bit.
mongodben
requested changes
Apr 10, 2025
mongodben
reviewed
Apr 22, 2025
| @@ -25,3 +25,4 @@ export * from "./References"; | |||
| export * from "./VectorStore"; | |||
| export * from "./arrayFilters"; | |||
| export * from "./assertEnvVars"; | |||
| export * from "./mongoDbMetadata"; | |||
There was a problem hiding this comment.
Suggested change
| export * from "./mongoDbMetadata"; |
pls do this as a named export. in the PR #678, i added much of the metadata stuff.
it's exported as mongodb-rag-core/mongoDbMetadata.
pls update the imports throught this PR accordingly.
mongodben
reviewed
Apr 22, 2025
There was a problem hiding this comment.
export this from mongoDbMetadata/index.ts
mongodben
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-923
Changes
Notes