(EAI-950) Segment - Send data feed to Segment #679
Conversation
| segmentUserId: res.locals.customData.segmentUserId ?? "NOPE", | ||
| segmentAnonymousId: res.locals.customData.segmentAnonymousId ?? "NOPE", |
There was a problem hiding this comment.
can you do null rather than 'NOPE'? or does 'NOPE' mean something to segment
There was a problem hiding this comment.
Oops did that for testing purposes and used a silly word so that I'd notice it later. Good catch!
| if (userMessage) { | ||
| segmentTrackUserSentMessage?.({ | ||
| userId, | ||
| anonymousId, | ||
| conversationId: conversation._id, | ||
| origin: userMessage.customData?.origin as string, | ||
| createdAt: userMessage.createdAt, | ||
| tags: tracingData.tags, | ||
| }); | ||
| } | ||
|
|
||
| const assistantMessage = tracingData.assistantMessage; | ||
| if (userMessage && assistantMessage) { | ||
| segmentTrackAssistantResponded?.({ | ||
| userId, | ||
| anonymousId, | ||
| conversationId: conversation._id, | ||
| origin: userMessage.customData?.origin as string, | ||
| createdAt: assistantMessage.createdAt, | ||
| isVerifiedAnswer: tracingData.isVerifiedAnswer ?? false, | ||
| rejectionReason: tracingData.rejectQuery | ||
| ? (assistantMessage.customData?.rejectionReason as | ||
| | string | ||
| | undefined) ?? "Unknown rejection reason" | ||
| : undefined, | ||
| }); | ||
| } | ||
|
|
||
| logger.updateSpan({ |
There was a problem hiding this comment.
now that there are 2 separate things happening in this trace func, should we wrap each w/ a try/catch block?
i know both aren't async, since the processing happening in background..but still.
not sure what right approach is, but wanted to raise the question
There was a problem hiding this comment.
Good call - added try catch. Also needed a mongodb-chatbot-server update so that we pass the reqId for logging
| res.locals.customData.segmentUserId = userId; | ||
| } | ||
| if (anonymousId) { | ||
| res.locals.customData.segmentAnonymousId = anonymousId; |
There was a problem hiding this comment.
by including this, does it mean that we're now tracking the segment user and anon IDs in the DB?
There was a problem hiding this comment.
Yes we will track these in user message customData. I think they classify as PII so don't want to keep them in scrubbed_messages.
|
out of curiousity, whaat do the segment ID and anon IDs look like? and where are they coming from? can we connect a segment ID back to a real user, like w/ email or smthn? |
They're UUIDs with slightly different formats, e.g.
They're stored in localStorage on MongoDB web properties that include Segment's AnalyticsJS (pretty much all of our sites, including docs)
I think the |
Jira: (EAI-950) Segment - Send data feed to Segment
Changes
useSegmentIdsmiddleware to pull out Segment user IDs from request headerssegmenthandlers that send chatbot events to SegmentSEGMENT_WRITE_KEYenv var to route requests