-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4525 Transition the existing test_database.py test to be asynchronous #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggested fixes for the typechecking failures, but great start!
7860e51
to
34b0e69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more cleanup and typing fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, let's wait until #1718 is merged and then rebase to get the changes into the top-level test/test_database.py
.
@shruti-sridhar #1718 is merged, go ahead and rebase these changes onto master to resolve the merge conflict. |
957a8d1
to
56f35e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few cleanup comments, but otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR converts the existing
test/test_database.py
test to be asynchronous and generates the synchronous version.