Skip to content

PYTHON-4525 Transition the existing test_database.py test to be asynchronous #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

shruti-sridhar
Copy link
Contributor

This PR converts the existing test/test_database.py test to be asynchronous and generates the synchronous version.

@shruti-sridhar shruti-sridhar requested a review from NoahStapp June 26, 2024 21:49
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested fixes for the typechecking failures, but great start!

Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more cleanup and typing fixes.

@shruti-sridhar shruti-sridhar requested a review from NoahStapp June 27, 2024 18:32
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, let's wait until #1718 is merged and then rebase to get the changes into the top-level test/test_database.py.

@NoahStapp
Copy link
Contributor

Overall looks good, let's wait until #1718 is merged and then rebase to get the changes into the top-level test/test_database.py.

@shruti-sridhar #1718 is merged, go ahead and rebase these changes onto master to resolve the merge conflict.

Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cleanup comments, but otherwise looks good!

@shruti-sridhar shruti-sridhar requested a review from NoahStapp July 2, 2024 20:33
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shruti-sridhar shruti-sridhar merged commit f5b102a into mongodb:master Jul 3, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants