Skip to content

PYTHON-5292 - Debug logs should only print on failed tests #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 21, 2025

Conversation

NoahStapp
Copy link
Contributor

@NoahStapp NoahStapp commented Apr 17, 2025

Note: this PR does not turn on debug logs by default in our Evergreen tests. That will be tracked in a separate, follow-up ticket.

@@ -15,6 +15,7 @@

import enum
import logging
import logging.handlers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, good catch!

@NoahStapp NoahStapp requested a review from blink1073 April 18, 2025 15:31
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit 0ee8e58 into mongodb:master Apr 21, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants