Skip to content

Revert need for cmake install in CI #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert need for cmake install in CI #3153

wants to merge 2 commits into from

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Apr 12, 2025 •
edited
Loading

Description

  • Revert need for cmake install in CI (except for TI targets)
  • Remove need for ninja install in CI (except for TI targets)

Motivation and Context

Both are now handled correctly by the CI image.
Linked to actions/runner-images#11926 and actions/runner-images#11737

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Streamlined the build pipeline by commenting out and removing specific installation steps for CMake and Ninja, resulting in a more efficient process across multiple target environments.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 12, 2025 •
edited
Loading

Walkthrough

The changes modify two Azure pipeline configuration files. In both files, steps referencing templates for downloading and installing CMake and Ninja have been removed across multiple build jobs. In azure-pipelines-nightly.yml, these steps are commented out in three jobs, while in azure-pipelines.yml, they are removed in four jobs. The remainder of each job’s steps remains unchanged, preserving the overall structure and flow.

Changes

File Change Summary
azure-pipelines-nightly.yml Commented out template steps for downloading/installing CMake and Ninja in jobs: Build_STM32_targets, Build_TI_SimpleLink_targets, Build_Azure_RTOS_targets.
azure-pipelines.yml Removed template steps for downloading/installing CMake and Ninja in jobs: Build_STM32_targets, Build_NXP_targets, Build_TI_SimpleLink_targets, Build_Azure_RTOS_targets.

Sequence Diagram(s)

sequenceDiagram
    participant Job as Pipeline Job
    participant CMake as CMake Installer
    participant Ninja as Ninja Installer
    participant Build as Build Steps

    Job->>CMake: Check CMake installation step (disabled)
    CMake-->>Job: Skipped
    Job->>Ninja: Check Ninja installation step (disabled)
    Ninja-->>Job: Skipped
    Job->>Build: Execute remaining build steps
Loading

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7bc3b9e and 1de372e.

📒 Files selected for processing (2)
  • azure-pipelines-nightly.yml (0 hunks)
  • azure-pipelines.yml (0 hunks)
💤 Files with no reviewable changes (2)
  • azure-pipelines-nightly.yml
  • azure-pipelines.yml
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@networkfusion
Copy link
Member Author

networkfusion commented Apr 12, 2025 •
edited
Loading

The issue with TI_CC1352R1_LAUNCHXL_915) seems unrelated to this PR (but possibly needs the TI SDK to support nodejs 18+).

@networkfusion
Revert need for cmake install in CI
7bc3b9e 
Remove need for ninja install in CI
Both are now handled correctly by the image.
@networkfusion networkfusion force-pushed the networkfusion/ci-improvements branch from eec4297 to 7bc3b9e Compare April 12, 2025 19:29
@josesimoes
Copy link
Member

Interestingly building TI just went OK as usual...
https://dev.azure.com/nanoframework/nf-interpreter/_build/results?buildId=55396&view=logs&j=71381b5f-e32c-5829-af59-91a8e4b35b1f

Not sure what's going on here... Let's try again.

josesimoes
josesimoes reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the lines instead of commenting them out.

@networkfusion
Copy link
Member Author

networkfusion commented Apr 14, 2025 •
edited
Loading

I would rather remove the lines instead of commenting them out.

I will remove them from the ST and NXP targets, but will re-add to the TI, until we can work out why it continues to fail.

@networkfusion
Fix TI build
1de372e 
Clean-up other targets
@josesimoes
Copy link
Member

Ongoing investigation on the root cause.

@josesimoes
Copy link
Member

Looks like it's OK to use Ninja in CMake context (most of the build jobs run successfully) but "standalone" is not possible.
This was demonstrated in this pipeline run:
https://dev.azure.com/nanoframework/nf-interpreter/_build/results?buildId=55404&view=logs&j=71381b5f-e32c-5829-af59-91a8e4b35b1f&t=1551473c-b74d-5f56-a947-fe5f30146f12&l=14

I've raised an issue about this here: actions/runner-images#12026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: Config-and-Build Status: Blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@networkfusion @josesimoes @nfbot