Skip to content

feat(dialogs/spawnDialog)!: replace onClose callback with Promise #6759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

feat(dialogs/spawnDialog)!: replace onClose callback with Promise #6759

merged 1 commit into from
Apr 10, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 8, 2025 •
edited
Loading

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews 💥 breaking PR that requires a new major version feature: functions composables, functions, mixins and other non-components labels Apr 8, 2025
@ShGKme ShGKme added this to the v9.0.0-rc.0 milestone Apr 8, 2025
@ShGKme ShGKme requested a review from susnux April 8, 2025 15:07
@ShGKme ShGKme self-assigned this Apr 8, 2025
This was referenced Apr 8, 2025
Merged
Merged
susnux
susnux reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ShGKme ShGKme force-pushed the feat/spawnDialog--promise-only branch from 2c22e31 to 06f2be4 Compare April 10, 2025 14:33
@ShGKme ShGKme requested review from st3iny and Antreesy April 10, 2025 14:35
@ShGKme ShGKme marked this pull request as ready for review April 10, 2025 14:35
susnux
susnux approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this one for v9

@ShGKme ShGKme force-pushed the feat/spawnDialog--promise-only branch from 06f2be4 to 806005c Compare April 10, 2025 16:54
@ShGKme ShGKme force-pushed the feat/spawnDialog--promise-only branch from 806005c to d7f8a08 Compare April 10, 2025 16:55
@ShGKme ShGKme enabled auto-merge April 10, 2025 16:56
@ShGKme ShGKme merged commit a980a81 into main Apr 10, 2025
28 checks passed
@ShGKme ShGKme deleted the feat/spawnDialog--promise-only branch April 10, 2025 16:58
@susnux susnux mentioned this pull request Apr 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews 💥 breaking PR that requires a new major version enhancement New feature or request feature: functions composables, functions, mixins and other non-components
Projects
None yet
Milestone
v9.0.0-rc.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @susnux @Antreesy