[IMP] adapt code to new simplified safe_eval API
#265
+31
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
upgradeci retry with always only hr in all versions |
aj-fuentes
reviewed
Apr 23, 2025
KangOl
force-pushed
the
master-safe-eval-refactor-globals-roan
branch
from
963dd2a to
decb2d7
Compare
antonrom1
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 24, 2025
This commit simplifies `safe_eval` which, up until now, allowed passing global and local namespaces. There is no usecase for this anymore. We want safe_eval exec mode to behave like a top-level module scope. `nocopy` is not needed anymore either. It's a relic of when the context could be dynamic (e.g. for already deleted `RecordDictWrapper` or `QWebContext`). Passed in context is always a dict. It will always be mutated with the local eval namespace dict after evaluation. This all makes `safe_eval` API less confusing. see enterprise: odoo/enterprise#83818 see upgrade-util: odoo/upgrade-util#265 task-4378806
antonrom1
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 24, 2025
This commit simplifies `safe_eval` which, up until now, allowed passing global and local namespaces. There is no usecase for this anymore. We want safe_eval exec mode to behave like a top-level module scope. `nocopy` is not needed anymore either. It's a relic of when the context could be dynamic (e.g. for already deleted `RecordDictWrapper` or `QWebContext`). Passed in context is always a dict. It will always be mutated with the local eval namespace dict after evaluation. This all makes `safe_eval` API less confusing. See: odoo/enterprise#83818 See: odoo/upgrade-util#265 task-4378806
`safe_eval` loose the `nocopy` option. As we rely on it when evaluating expression, we need to reimplement `safe_eval` to do the evaluation using the `SelfPrintEvalContext`. See odoo/odoo#206846 See odoo/enterprise#83818
KangOl
force-pushed
the
master-safe-eval-refactor-globals-roan
branch
from
decb2d7 to
5b158c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safe_evalloose thenocopyoption. As we rely on it when evaluating expression, we need to reimplementsafe_evalto do the evaluation using theSelfPrintEvalContext.See odoo/odoo#206846
See odoo/enterprise#83818