Add WarpPerspective in FastCV extension #3922
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
Apr 10, 2025
Comment on lines
22
to
23
| * @param _src Input 8-bit image. Size of buffer is srcStride*srcHeight bytes. | ||
| * @param _dst Output 8-bit image. Size of buffer is dstStride*dstHeight bytes. |
There was a problem hiding this comment.
Please remove the information about sizes. The destination buffer is allocated by the function itself automatically.
| ::testing::Values(perf::szVGA, perf::sz720p, perf::sz1080p)) | ||
| { | ||
| cv::Size dstSize = GetParam(); | ||
| cv::Mat img = imread(cvtest::findDataFile("cv/shared/baboon.png")); |
There was a problem hiding this comment.
Add EXPECT_FALSE(img.empty()); after the line to check that test input is not empty.
| int borderType = get<2>(GetParam()); | ||
| cv::Scalar borderValue = Scalar::all(100); | ||
|
|
||
| cv::Mat src = imread(cvtest::findDataFile("cv/shared/baboon.png"), cv::IMREAD_GRAYSCALE); |
modules/fastcv/test/test_warp.cpp
Outdated
Comment on lines
50
to
51
| dst1.create(dstSize, CV_8UC1); | ||
| dst2.create(dstSize, CV_8UC1); |
There was a problem hiding this comment.
There is no sense to create output buffer before the call. The further function should do it for you.
modules/fastcv/test/test_warp.cpp
Outdated
| cv::Mat src = imread(cvtest::findDataFile("cv/shared/baboon.png"), cv::IMREAD_GRAYSCALE); | ||
| cv::Mat dst, matrix, ref; | ||
| matrix.create(3, 3, CV_32FC1); | ||
| dst.create(dstSize, src.type()); |
There was a problem hiding this comment.
There is no sense to create output buffer before the call. The further function should do it for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.