Skip to content

ofTrueTypeFont mesh insert at once #8432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Apr 19, 2025

No description provided.

@dimitre dimitre marked this pull request as draft April 19, 2025 17:42
@dimitre
Copy link
Member Author

dimitre commented Apr 20, 2025

I'm loving to look at the errors here:

../../../libs/openFrameworks/graphics/ofTrueTypeFont.cpp:1021:3: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'unsigned short' in initializer list [-Wc++11-narrowing]
 1021 |                 firstIndex + 1U,

ofIndexType is an alias to TESSIndex. does it need to be?
TESSIndex vary from platform to platform? Ins't unsigned short is too short to represent indices?
What about this was fixed std::size_t for all platforms?

@dimitre dimitre marked this pull request as ready for review April 20, 2025 12:44
@dimitre dimitre marked this pull request as draft April 20, 2025 12:57
@ofTheo
Copy link
Member

ofTheo commented Apr 21, 2025

@dimitre there is definitely a historical reason for ofIndexType being TESSIndex - something with max buffer sizes on memory constrained devices?
I can't remember 100%, but I wouldn't change it unless there is bug that it solves.

@dimitre dimitre marked this pull request as ready for review April 21, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants