Sorted displaying of the blocking snapshots list #17264
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When multiple snapshots prevent the destruction/rollback of the respective dataset/snapshot/volume via
zfs destroy
orzfs rollback
, the error message does not list the blocking snapshots sorted according to their order of creation.This causes inconvenience and can lead to confusion, and also creates a contrast with a returned message from
zfs list -t snap
function.#12751
Description
The
zfs_iter_snapshots_v2
functions used in these cases are replaced byzfs_iter_snapshots_sorted_v2
Prepare:
Before:
After:
How Has This Been Tested?
Run the commands in the different combinations.
Types of changes
Checklist:
Signed-off-by
.