Add Type::spliceArray(), improve splice_array() array type narrowing
#3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
commented
Apr 19, 2025
| * @var array{a: 0, b: 1, c?: 2} $arr | ||
| */ | ||
| array_splice($arr, 0, -1, ['hello']); | ||
| assertType('array{0: \'hello\', c?: 2}', $arr); // Could be array{0: 'hello', b?: 1, c?: 2} |
There was a problem hiding this comment.
Some types with either negative offsets or negative limits are not optimal but this one is wrong. Not sure what to do here tbh., the handling of those is extremely hard in combination with optional keys. Without optional keys my current approach seems to work fine.
Ideas about this
- Keep and see if it causes any issues
- Degrade to general array if negative offsets/limits are involved in combination with optional keys
- Rewrite and do something semi-crazy with maybe
getFiniteTypes()and avoid optional keys completely but have some constant array unions instead
What do you think? Or any other ideas?
herndlm
force-pushed
the
array-splice
branch
2 times, most recently
from
558dec9 to
8425b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11917
This is very similar to
Type:: sliceArray()and it is used inNodeScopeResolverin a similar fashion asType::popArray()is. Moving logic toTypedeals obviously with all accessory types which were not working properly before too like e.g. list or non-empty-array. The only thing I'm slightly worried about is the constant array type handling which is not perfect.First commit is a tiny refactor I didn't want to cause more noise and dependencies with another PR..