gh-132578: Rename the threading.Thread._handle field
#132696
Open
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit `0e9c364f` introduced the `_handle` field on instances of `threading.Thread`. Unfortunately it's fairly common for subclasses of `threading.Thread` to define a `_handle()` method, which is shadowed by the new field.
colesbury
approved these changes
Apr 18, 2025
|
I'm on the fence about backporting this to 3.13. It has the potential to break code that's started relying on How common is the breakage? How much does this block from upgrading to 3.13? |
pitrou
approved these changes
Apr 19, 2025
|
3.13.3 is out already, it sounds unlikely that some library wanting to support 3.13 is still blocked by this bug (the workaround is near trivial). So my vote is against backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0e9c364 introduced the
_handlefield on instances ofthreading.Thread. Unfortunately it's fairly common for subclasses ofthreading.Threadto define a_handle()method, which is shadowed by the new field.Search results on GitHub suggests that the new name is unlikely to collide with existing code (results for the old name).
Name mangling is a bit of an awkward fit here because subclasses of
threading.Threadneed access to the handle.