Skip to content

Github Action para ejecutar powrap fix con un comentario #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: 3.13
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
9f36e72
wip: github action to run pospell
erickisos Feb 13, 2022
4784132
fix: execute only on PR
erickisos Oct 3, 2022
b60f901
Apply suggestions from code review
erickisos Oct 3, 2022
94a5617
rename and add continue-on-error
erickisos Oct 3, 2022
4c88e59
one liner to avoid confusion
erickisos Oct 3, 2022
8a35070
Merge pull request #1 from erickisos/github-actions
erickisos Oct 4, 2022
5e8294d
Update check_spell.py
erickisos Oct 4, 2022
e97b234
delete duplicated file
erickisos Oct 4, 2022
a298acd
fix createforIssueComment
erickisos Oct 4, 2022
89efe08
Merge pull request #2 from erickisos/erickisos-patch-1
erickisos Oct 4, 2022
c6cd5c9
react to comment
erickisos Oct 4, 2022
4660c60
Merge pull request #3 from erickisos/fix-reaction
erickisos Oct 4, 2022
48359fa
Update pospell-on-demand.yml
erickisos Oct 5, 2022
1f6c82f
add cache apt action
erickisos Oct 5, 2022
ecc94e1
fix: add apt cache
erickisos Oct 5, 2022
284a519
Merge pull request #4 from erickisos/erickisos-patch-1
erickisos Oct 5, 2022
b620336
Merge branch '3.10' into fix-reaction
erickisos Oct 5, 2022
0e43eca
Merge pull request #5 from erickisos/fix-reaction
erickisos Oct 5, 2022
beb9bfe
Rollback a check_spell
erickisos Oct 5, 2022
75fd847
Update scripts/check_spell.py
erickisos Oct 5, 2022
55fe5e7
Apply suggestions from code review
erickisos Oct 5, 2022
0f8c793
Update .github/workflows/pospell-on-demand.yml
erickisos Oct 5, 2022
fe0bbda
Rename pospell-on-demand.yml to execute-powrap.yml
erickisos Oct 5, 2022
64a4e23
Merge branch 'python:3.10' into 3.10
erickisos Oct 6, 2022
2bcf7ea
rollback to previous commit action
erickisos Oct 8, 2022
26e3093
Merge pull request #8 from erickisos/rollback-push-action
erickisos Oct 8, 2022
da6981a
Add branch name to action-js
erickisos Oct 8, 2022
3f5ac33
Merge pull request #9 from erickisos/sent-branch-name
erickisos Oct 8, 2022
b821192
Update execute-powrap.yml
erickisos Oct 8, 2022
bbef6e3
Merge pull request #10 from erickisos/erickisos-patch-3
erickisos Oct 8, 2022
111a24d
Update execute-powrap.yml
erickisos Oct 8, 2022
c03192f
Merge pull request #11 from erickisos/erickisos-patch-3
erickisos Oct 8, 2022
0b465a5
Merge branch '3.10' into 3.10
erickisos Oct 26, 2022
5f3b136
Reducir la carga eliminando otras dependencias
erickisos Oct 28, 2022
c609c52
Merge branch '3.13' into 3.10
erickisos Nov 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/pospell-on-demand.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: pospell
on:
issue_comment:
types:
- edited
- created

jobs:
fix-spell:
name: Fix spelling
runs-on: ubuntu-latest
if: ${{ github.event.issue.pull_request && github.event.comment.body == 'pospell-fix' }}
steps:
- name: Confirmar ejecucion
continue-on-error: true
run: |
curl ${{github.event.comment.url}}/reactions \
-X POST \
-d '{"content":"+1"}' \
-H "Accept: application/vnd.github.squirrel-girl-preview+json" \
-H "Authorization: token ${{ secrets.GITHUB_TOKEN }}"
- uses: actions/checkout@v3
- uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: hunspell hunspell-es gettext
version: 1.0
- name: Preparar Python v3.10
uses: actions/setup-python@v4
with:
python-version: "3.10"
cache: "pip"
- name: Instalar dependencias
run: python -m pip install -r requirements.txt
- name: Ejecutar Powrap
run: powrap --quiet **/*.po
- name: Revisar con Pospell
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como mencionaba en el otro PR, pospell no hace ningún cambio local en tus archivos, sólo chequea si la ortografía es correcta o no, y retorna con status 0 o distinto a 0 dependiendo de si encontró errores. Esto significa que hacer chequeo ortográfico no tiene incidencia alguna en el paso siguiente (hacer un commit con los cambios locales), por lo que encuentro que no tiene mucho sentido ejecutar pospell en primer lugar -- aparte que hace que la acción se demore más en terminar.

En mi opinión la acción debería estar centrada solo en ejecutar powrap y hacer el commit con los cambios que este encuentre, nada más (al menos esa era mi intención al crear #1786). Por eso también insistía en que los nombres del archivo, de la acción, etc, estuvieran todos centrados en powrap, no en pospell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh vaya, got it, déjame hacer esos cambios de una, la verdad no me había quedado claro 😅

run: python scripts/check_spell.py
continue-on-error: true
- name: Commit & Push changes
uses: actions-js/push@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tambien hay esta action que parece hacer el mismo, pero en el marketplace tiene 1k star (actions-js/push solo tiene 38).
Nunca las he probado, así que no puedo decirte cuál es la mejor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hice el cambio solo para hacer la prueba, si vemos que no nos funciona as expected, le damos de vuelta a la que teníamos

with:
message: "auto: spell check"
github_token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion scripts/check_spell.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
with open(output_filename, "w") as f:
for e in entries:
f.write(e)
f.write("\n")
f.write('\n')

# Run pospell either against all files or the file given on the command line
po_files = sys.argv[1:]
Expand Down