Skip to content

fix TaskFactory and loop.create_task #13687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix TaskFactory and loop.create_task #13687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
defca70
fix TaskFactory and loop.create_task
graingert Mar 20, 2025
3a2d455
can't be as precise as 3.13.2
graingert Mar 20, 2025
48f5574
enfixen
graingert Mar 20, 2025
a7fe614
Merge branch 'main' into fix-task-factory-and-loop-create-task
graingert Apr 9, 2025
ea6b3b0
Merge branch 'main' into fix-task-factory-and-loop-create-task
graingert Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion stdlib/asyncio/base_events.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import ssl
import sys
from _asyncio import _TaskCompatibleCoro
from _typeshed import FileDescriptorLike, ReadableBuffer, WriteableBuffer
from asyncio import _AwaitableLike, _CoroutineLike
from asyncio.events import AbstractEventLoop, AbstractServer, Handle, TimerHandle, _TaskFactory
Expand Down Expand Up @@ -83,7 +84,16 @@ class BaseEventLoop(AbstractEventLoop):
# Future methods
def create_future(self) -> Future[Any]: ...
# Tasks methods
if sys.version_info >= (3, 11):
if sys.version_info >= (3, 13): # all Task kwargs added in 3.13.2
def create_task(
self,
coro: _TaskCompatibleCoro[_T],
*,
name: str | None = None,
context: Context | None = None,
eager_start: bool | None = None,
) -> Task[_T]: ...
elif sys.version_info >= (3, 11):
def create_task(self, coro: _CoroutineLike[_T], *, name: object = None, context: Context | None = None) -> Task[_T]: ...
else:
def create_task(self, coro: _CoroutineLike[_T], *, name: object = None) -> Task[_T]: ...
Expand Down
31 changes: 28 additions & 3 deletions stdlib/asyncio/events.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import sys
from _asyncio import (
_get_running_loop as _get_running_loop,
_set_running_loop as _set_running_loop,
_TaskCompatibleCoro,
get_event_loop as get_event_loop,
get_running_loop as get_running_loop,
)
Expand Down Expand Up @@ -67,8 +68,22 @@ _ExceptionHandler: TypeAlias = Callable[[AbstractEventLoop, _Context], object]
_ProtocolFactory: TypeAlias = Callable[[], BaseProtocol]
_SSLContext: TypeAlias = bool | None | ssl.SSLContext

class _TaskFactory(Protocol):
def __call__(self, loop: AbstractEventLoop, factory: _CoroutineLike[_T], /) -> Future[_T]: ...
if sys.version_info >= (3, 13): # all Task kwargs added in 3.13.2
class _TaskFactory(Protocol):
def __call__(
self,
loop: AbstractEventLoop,
coro: _TaskCompatibleCoro[_T],
/,
*,
name: str | None = ...,
context: Context | None = None,
eager_start: bool = False,
) -> Task[_T]: ...

else:
class _TaskFactory(Protocol):
def __call__(self, loop: AbstractEventLoop, coro: _CoroutineLike[_T], /) -> Task[_T]: ...

class Handle:
_cancelled: bool
Expand Down Expand Up @@ -157,7 +172,17 @@ class AbstractEventLoop:
@abstractmethod
def create_future(self) -> Future[Any]: ...
# Tasks methods
if sys.version_info >= (3, 11):
if sys.version_info >= (3, 13): # all Task kwargs added in 3.13.2
@abstractmethod
def create_task(
self,
coro: _TaskCompatibleCoro[_T],
*,
name: str | None = None,
context: Context | None = None,
eager_start: bool | None = None,
) -> Task[_T]: ...
elif sys.version_info >= (3, 11):
@abstractmethod
def create_task(
self, coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None
Expand Down
Loading