[fpdf2] Update to 2.8.3 #13871
Open
[fpdf2] Update to 2.8.3 #13871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
donBarbos
reviewed
Apr 23, 2025
This comment has been minimized.
This comment has been minimized.
donBarbos
reviewed
Apr 23, 2025
Co-authored-by: Semyon Moroz <[email protected]>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@donBarbos If you have the time, I'd be happy about a review of this PR. |
donBarbos
approved these changes
Apr 24, 2025
Comment on lines
+93
to
+98
| start_circle_x: int, | ||
| start_circle_y: int, | ||
| start_circle_radius: int, | ||
| end_circle_x: int, | ||
| end_circle_y: int, | ||
| end_circle_radius: int, |
There was a problem hiding this comment.
forgot mark it here:
Suggested change
| start_circle_x: int, | |
| start_circle_y: int, | |
| start_circle_radius: int, | |
| end_circle_x: int, | |
| end_circle_y: int, | |
| end_circle_radius: int, | |
| start_circle_x: float, | |
| start_circle_y: float, | |
| start_circle_radius: float, | |
| end_circle_x: float, | |
| end_circle_y: float, | |
| end_circle_radius: float, |
| @@ -180,6 +210,17 @@ class FPDF(GraphicsStateMixin): | |||
| @property | |||
| def page_mode(self) -> PageMode: ... | |||
There was a problem hiding this comment.
it's not your changes, but looks like we can add missing method:
Suggested change
| def page_mode(self) -> PageMode: ... | |
| def page_mode(self) -> PageMode: ... | |
| @page_mode.setter | |
| def page_mode(self, page_mode: PageMode) -> None: ... |
| @@ -26,7 +26,7 @@ def convert_unit( | |||
|
|
|||
| ROMAN_NUMERAL_MAP: Final[tuple[tuple[str, int], ...]] | |||
|
|
|||
| def int2roman(n: int) -> str: ... | |||
| def int2roman(n: int | None) -> str: ... | |||
There was a problem hiding this comment.
if you want we can use overload but then we will have to import overload:
Suggested change
| def int2roman(n: int | None) -> str: ... | |
| @overload | |
| def int2roman(n: None) -> Literal[""]: ... | |
| @overload | |
| def int2roman(n: int) -> str: ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13869