Deprecate several things in mypy_extensions
#13874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See python/mypy_extensions@1.0.0...1.1.0 on what was deprecated.
hauntsaninja
approved these changes
Apr 23, 2025
AlexWaygood
reviewed
Apr 23, 2025
| @@ -37,6 +38,7 @@ class _TypedDict(Mapping[str, object], metaclass=abc.ABCMeta): | |||
| # supposedly incompatible definitions of `__or__` and `__ior__`: | |||
| def __ior__(self, value: Self, /) -> Self: ... # type: ignore[misc] | |||
|
|
|||
| @deprecated("mypy_extensions.TypedDict is deprecated, use typing.TypedDict instead") | |||
There was a problem hiding this comment.
I think a better message here would have been
Suggested change
| @deprecated("mypy_extensions.TypedDict is deprecated, use typing.TypedDict instead") | |
| @deprecated("Use typing.TypedDict or typing_extensions.TypedDict instead") |
Both mypy and pyright include the phrase "X is deprecated" in their error message even if it's not included in the string passed to @deprecated, so I think we should generally avoid saying "X is deprecated" in these messages. We'll just be repeating things the type checker is already saying:
- https://mypy-play.net/?mypy=latest&python=3.12&enable-error-code=deprecated&gist=9558d65312b99c1ac2a28863ffadde33
- https://pyright-play.net/?pythonVersion=3.12&strict=true&enableExperimentalFeatures=true&code=GYJw9gtgBALgngBwJYDsDmB9ApgDxllAZyTCKiQgTBBigBMsEQsBjAQ3zoCguABBpqw5Y6ACgBEwMGHEBKLg2BQARmxCjZUALQA%2BKADlSWAFxQAdBZ6r18vgObtOEmAAssKtgC8owAK4oWGBIUckJ6RgdhOjkFLCVVTw1tPUMUE3NLLgSNIA
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision)
- torchvision/utils.py:270: error: Unused "type: ignore" comment [unused-ignore]
|
|
I opened #13876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/mypy_extensions@1.0.0...1.1.0 on what was deprecated.