-
Notifications
You must be signed in to change notification settings - Fork 306
Add ABI Day Cloud Type ("cloud_type") RGB #3089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add ABI Day Cloud Type ("cloud_type") RGB #3089
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3089 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 391 391
Lines 56633 56633
=======================================
Hits 54471 54471
Misses 2162 2162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 14538111256Details
💛 - Coveralls |
Just for your information, there is also the |
satpy also has a version that uses the sunz_reduced modifier (for FCI). In DWD, we have swapped this for the satpy/satpy/etc/composites/fci.yaml Lines 317 to 331 in 0a00879
I understand sunz_corrected is already applied to ABI data, but is this reduced near the terminator in any way? |
VIIRS SDR has the sunz corrected applied in the reader, but not ABI. ABI requires it to be specified in the composite recipe if it is desired. And no reduction is done other than @strandgren Thanks. Maybe I'll add that URL to this recipe. I had noticed the CIMSS variant but also that it didn't match what the CIRA/NASA/NOAA guide had. I do not like RGBs. |
At the RGB workshop, it was decided this composite should be called |
Yeah I will rename this one and I'll probably make a separate PR to rename and deprecate other RGBs for ABI. For example, The enhancements can be configured by "reader" so there is at least that control. I did actually need to do that in my Polar2Grid project for this RGB where Satpy was matching with a L2 product clavrx product's enhancement for "cloud_type" versus this one. I had to add "reader" to the L2 version. Anyway...I'll try to find time for this and the other RGBs today. |
36553ae
to
22613dd
Compare
@mraspaud can you double check this? I think I made all the changes you requested. |
New ABI composite. Almost the exact same thing as day cloud phase distinction but different red channel.
AUTHORS.md
if not there already