Skip to content

Fci l1c handle other coverage #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

ClementLaplace
Copy link
Contributor

@ClementLaplace ClementLaplace commented Apr 22, 2025

This PR is dedicated to handle other coverages regarding the fci_l1c reader.

  • Tests applied for the fci_l1c reader

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (f15bd3b) to head (f8c8737).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3112    +/-   ##
========================================
  Coverage   96.18%   96.19%            
========================================
  Files         391      393     +2     
  Lines       56633    56745   +112     
========================================
+ Hits        54471    54584   +113     
+ Misses       2162     2161     -1     
Flag Coverage Δ
behaviourtests 3.82% <0.00%> (-0.01%) ⬇️
unittests 96.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Apr 22, 2025

Pull Request Test Coverage Report for Build 14594025837

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 96.295%

Totals Coverage Status
Change from base Build 14401317584: 0.009%
Covered Lines: 54839
Relevant Lines: 56949

💛 - Coveralls

@ClementLaplace ClementLaplace marked this pull request as ready for review April 22, 2025 07:51
Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Clement, thanks for this! Is there a reason why you haven't added the new fixture to the test test_count_in_repeat_cycle_rc_period_min here

def test_count_in_repeat_cycle_rc_period_min(self, reader_configs, fh_param, compare_tuples):
? It looks to me like that one is the most relevant test for this change, checking that the nominal time is computed correctly...

@ameraner ameraner added enhancement code enhancements, features, improvements component:readers labels Apr 22, 2025
@ClementLaplace
Copy link
Contributor Author

@ameraner you are right !! I have added the tests related to test_count_in_repeat_cycle_rc_period_min.

@ClementLaplace ClementLaplace requested a review from ameraner April 22, 2025 12:10
Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mraspaud mraspaud merged commit 5745cbb into pytroll:main Apr 23, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants