-
Notifications
You must be signed in to change notification settings - Fork 306
Fci l1c handle other coverage #3112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fci l1c handle other coverage #3112
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3112 +/- ##
========================================
Coverage 96.18% 96.19%
========================================
Files 391 393 +2
Lines 56633 56745 +112
========================================
+ Hits 54471 54584 +113
+ Misses 2162 2161 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 14594025837Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Clement, thanks for this! Is there a reason why you haven't added the new fixture to the test test_count_in_repeat_cycle_rc_period_min
here
satpy/satpy/tests/reader_tests/test_fci_l1c_nc.py
Line 1138 in a170b8e
def test_count_in_repeat_cycle_rc_period_min(self, reader_configs, fh_param, compare_tuples): |
…g the other coverage for hrfi and fhdsi
@ameraner you are right !! I have added the tests related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR is dedicated to handle other coverages regarding the
fci_l1c
reader.fci_l1c
reader