Adds a new auth backend that only accepts loopback connections #13767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
*Missing test cases, but wanted to get review on approach first. Added manual testing steps.
As discussed in #13205, this PR adds a new auth backend that works exactly like the internal one, but only accepts loopback connections. This PR does so by retrieving the socket in the plain auth mechanism and passes the socket through AuthProps to the auth_backend.
I'm able to test localhost connections, but haven't found a reliable way to test non-localhost connections.
It also accepts all loopback connections, not necessary only the
loopback_users
. This behavior is subject to change and open to thoughts on it.This PR is also set as draft, because it is missing a test suite for the new auth backend.
Manual testing performed
Setup
gmake run-broker
Test localhost conections
Both connect fine
Test non-localhost connections
(Note: I just manually changed
rabbit_net:is_loopback/1
to returnfalse
to test for now)Logs look like this for both attempts
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.