fix: correctly replace app name in file path #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue causing file paths to lose the first slash when using
RnDiffApp
as app name or an empty string after editing the input. A similar fix might need to be applied toappPackage
, but I refrained from doing so to avoid potential side effects on any underlying component, as the value can be nullable.I know there was already #379 open, but we used this fix in our fork and we thought it was good to contribute upstream. Feel free to ignore this PR if another fix is more suitable 😊
What are the steps to reproduce?
RnDiffApp
in the app name inputor
Checklist
README.md
(if needed)