Skip to content

DOC-4989 added node-js AMR page #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Mar 21, 2025

DOC-4989

I've worked from the repo README file and also incorporated some stuff from the other clients' AMR pages. Any suggestions or corrections are most welcome :-)

@andy-stark-redis andy-stark-redis self-assigned this Mar 21, 2025
Copy link
Contributor

@andy-stark-redis andy-stark-redis requested a review from a team March 21, 2025 12:00
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language LGTM. I did not validate the technical details. Just one question about a possibly superfluous asterisk (cheeky bugger). :)

@@ -100,7 +100,7 @@ below:
elapse before a refresh is triggered. For example, a value of 0.75 means the token
should be refreshed when 75% of its lifetime has elapsed.
- `retry`: This object specifies the policy to retry refreshing the token if the
first attempt fails. It has the following fields:
an error occurs. It has the following fields:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we forgot to remove "the" before "an error occurs"

Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor typo : we forgot to remove "the" before "an error occurs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants