fix: private variable detection to not match multiple dashes #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
changed the title
nex3
reviewed
Apr 8, 2025
| @@ -365,6 +365,10 @@ class _ModuleMigrationVisitor extends MigrationVisitor { | |||
| } | |||
| } | |||
|
|
|||
| bool _isPrivate(String name) { | |||
| return name.startsWith('-') && !name.startsWith('--'); | |||
There was a problem hiding this comment.
This logic isn't accurate. Names that start with multiple dashes are still private.
|
Superseding this with #275 so I can get a review from a colleague |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #273
This is not a fix for the conflicting patch that seems to happen though
npx sass-migrator module test.scss --remove-prefix=app
So I will draft until I find the cause of this