Popover: Add private component #1738
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixhabib
force-pushed
the
popover-component
branch
from
0c10a94 to
b643ec2
Compare
🦋 Changeset detectedLatest commit: d0e06b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
felixhabib
force-pushed
the
popover-component
branch
3 times, most recently
from
09f3954 to
d0e06b6
Compare
Fix useLayoutEffect
felixhabib
force-pushed
the
popover-component
branch
from
d0e06b6 to
b5540ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: This change results in a slight change to the
OverflowMenumenu positioning due to current implementation ofPopoverAPI. It is now positioned based on theOverflowMenuButtonIcon(not its bounding box with negative margins), in line with standard use ofMenuRendererandButtonIcon.This warrants some discussion before moving forward