Fix type checking for global variables such as __DEV__ #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checking could fail for globals such as
__DEV__.Specifically, it failed for the unit tests. While it did work for the example code, the tests only import
MyPanel.vueandMyPanelSection.vue, neither of which use__DEV__. The componentExampleComponent.vuedid use__DEV__, but wasn't imported in the tests.One way to fix this would have been to change the
includeintsconfig.vitest.jsonto includesrc/globals.d.ts, in addition toenv.d.ts.But it wasn't clear that two separate files are really needed for this. So the fix in this PR merges the contents of
src/globals.d.tsintoenv.d.ts.The example code has also been expanded to make greater use of
__DEV__, helping to catch any future problems. To try to keep the examples somewhat realistic, the new code usesprovide/inject. This has the added benefit of helping to test that those functions behave correctly, which is a common problem when a consuming application inadvertently has two copies of Vue present.