Skia: Fix no-wrap still wrapping text sometimes #8138
Draft
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
reviewed
Apr 14, 2025
|
You're right, with no-wrap that actually seems simpler. I don't recall why my mind insisted on laying out twice. Let's go with your version. I'll adjust :) |
tronical
force-pushed
the
simon/skia-no-wrap
branch
from
80aea5a to
443dcc5
Compare
|
Does this draw outside of the bounds? Should there be a clip applied? Does center and right alignment still works? |
|
Ok, so this is indeed overall a little trickier, laying with max width will require manual compensation for the alignment against f32::Max when drawing. Something for next week. |
tronical
force-pushed
the
simon/skia-no-wrap
branch
from
443dcc5 to
57fffca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7080