Skip to content

Added Exp and Ln functions to Slint #8226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added Exp and Ln functions to Slint #8226

wants to merge 5 commits into from

Conversation

bryce-happel-walton
Copy link

@bryce-happel-walton bryce-happel-walton commented Apr 22, 2025 •
edited
Loading

I felt these should be added, as they are already implemented in all used std math libraries, and it avoids developers defining e in their Slint code.

exp_m1 and ln_p1 would also be good addition for optimization, but I'll leave that up to the reviewers.

ChangeLog:

Added Exp function to Slint
Added Ln function to Slint
Added tests for Exp and Ln

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ogoffart
ogoffart approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks a lot for your contribution.

The only thing that I see could be a bit improved is to have more tests with more values. But the current state is still good enough for me.

@ogoffart
Copy link
Member

Oh, I forgot that this needs documentation (in math.mdx)

@bryce-happel-walton
Copy link
Author

Oh, I forgot that this needs documentation (in math.mdx)

Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart ogoffart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryce-happel-walton @CLAassistant @ogoffart