Skip to content

dev: add warning when context is undefined #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tommypop2
Copy link

@Tommypop2 Tommypop2 commented Apr 8, 2025

Summary

Using useContext outside of a provider can cause unforeseen and cryptic errors. This PR adds a warning (in dev) when the result of useContext is falsy.

See https://discord.com/channels/722131463138705510/1358899310116213008

Typescript does protect against using an undefined context somewhat, but I thought a warning could be nice, especially for new users.

How did you test this change?

Created a project and consumed a context without being in its provider:
image

Warning is printed to the console.

After the project has been built, the warning is not logged.

Copy link

changeset-bot bot commented Apr 8, 2025

⚠️ No Changeset found

Latest commit: bc6c19b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Tommypop2 Tommypop2 changed the title dev: add warning when context is null dev: add warning when context is undefined Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant