Skip to content

Add getRequiredName and hasName API to org.springframework.data.mapping.Parameter. #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add getRequiredName and hasName API to org.springframework.data.mapping.Parameter. #3272

wants to merge 1 commit into from

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Apr 18, 2025 •
edited
Loading

Introduces a more convenient API to simplify the caller side especially for conditionals that want to determine whether a parameter name is present.

Closes #3088

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 18, 2025
@onobc
Add getRequiredName and hasName API to `org.springframework.data.…
4cf55db 
…mapping.Parameter`.

Introduces a more convenient API to simplify the caller side especially for conditionals that want to determine whether a parameter name is present.

Closes spring-projects#3088
@onobc onobc force-pushed the GH-3088-Parameter-improvements branch from eae713b to 4cf55db Compare April 18, 2025 01:00
@onobc onobc requested a review from mp911de April 18, 2025 01:00
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 22, 2025
@mp911de mp911de added this to the 3.5 RC1 (2025.0.0) milestone Apr 22, 2025
mp911de pushed a commit that referenced this pull request Apr 22, 2025
@onobc @mp911de
Add getRequiredName and hasName API to `org.springframework.data.…
0e31401 
…mapping.Parameter`.

Introduces a more convenient API to simplify the caller side especially for conditionals that want to determine whether a parameter name is present.

Closes #3088
Original pull request: #3272
mp911de added a commit that referenced this pull request Apr 22, 2025
@mp911de
Polishing.
f5cfdc0 
Reorder methods. Tweak Javadoc, add references to parameter naming. Add usage to newly introduced methods.

See #3088
Original pull request: #3272
mp911de pushed a commit that referenced this pull request Apr 22, 2025
@onobc @mp911de
Add getRequiredName and hasName API to `org.springframework.data.…
a978209 
…mapping.Parameter`.

Introduces a more convenient API to simplify the caller side especially for conditionals that want to determine whether a parameter name is present.

Closes #3088
Original pull request: #3272
mp911de added a commit that referenced this pull request Apr 22, 2025
@mp911de
Polishing.
646aea4 
Reorder methods. Tweak Javadoc, add references to parameter naming. Add usage to newly introduced methods.

See #3088
Original pull request: #3272
@mp911de
Copy link
Member

mp911de commented Apr 22, 2025

That's merged, polished, and forward-ported now.

@mp911de mp911de closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5 RC1 (2025.0.0)
Development

Successfully merging this pull request may close these issues.

Introduce org.springframework.data.mapping.Parameter.getRequiredName() and Parameter.hasName()
3 participants
@onobc @mp911de @spring-projects-issues