Skip to content

fix: table alias can not find column #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
__pycache__
.DS_Store
.*.swp
.vscode

# Devenv
.envrc
Expand Down
9 changes: 5 additions & 4 deletions internal/compiler/output_columns.go
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,10 @@ func (c *Compiler) sourceTables(qc *QueryCatalog, node ast.Node) ([]*Table, erro
}
if n.Alias != nil {
table.Rel = &ast.TableName{
Catalog: table.Rel.Catalog,
Schema: table.Rel.Schema,
Name: *n.Alias.Aliasname,
Catalog: table.Rel.Catalog,
Schema: table.Rel.Schema,
Name: *n.Alias.Aliasname,
OriginalName: table.Rel.Name,
}
}
tables = append(tables, table)
Expand Down Expand Up @@ -656,7 +657,7 @@ func outputColumnRefs(res *ast.ResTarget, tables []*Table, node *ast.ColumnRef)
if schema != "" && t.Rel.Schema != schema {
continue
}
if alias != "" && t.Rel.Name != alias {
if alias != "" && t.Rel.Name != alias && t.Rel.OriginalName != alias {
continue
}
for _, c := range t.Columns {
Expand Down
31 changes: 31 additions & 0 deletions internal/endtoend/testdata/alias_join/mysql/go/db.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions internal/endtoend/testdata/alias_join/mysql/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

88 changes: 88 additions & 0 deletions internal/endtoend/testdata/alias_join/mysql/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions internal/endtoend/testdata/alias_join/mysql/query.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
-- name: RetrieveAllWithDeprecation :many
select
arn,
name,
aws_rds_databases.engine
from
aws_rds_databases r
natural join aws_rds_databases_engines
;

-- name: RetrieveAllWithDeprecationOther :many
select
arn,
name,
r.engine
from
aws_rds_databases r
natural join aws_rds_databases_engines
;
21 changes: 21 additions & 0 deletions internal/endtoend/testdata/alias_join/mysql/schema.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
CREATE TABLE IF NOT EXISTS aws_rds_databases (
account_id VARCHAR(20) NOT NULL,
region VARCHAR(20) NOT NULL,
arn VARCHAR(20) NOT NULL,
name TEXT NOT NULL,
engine TEXT NOT NULL,
engine_version TEXT NOT NULL,

-- tags is a JSON object
tags TEXT NOT NULL,

UNIQUE (account_id, region, arn)
);

CREATE TABLE IF NOT EXISTS aws_rds_databases_engines (
engine VARCHAR(20) NOT NULL,
engine_version VARCHAR(20) NOT NULL,
deprecation TEXT NOT NULL,

UNIQUE (engine, engine_version)
);
12 changes: 12 additions & 0 deletions internal/endtoend/testdata/alias_join/mysql/sqlc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"path": "go",
"engine": "mysql",
"name": "querytest",
"schema": "schema.sql",
"queries": "query.sql"
}
]
}
31 changes: 31 additions & 0 deletions internal/endtoend/testdata/alias_join/postgresql/go/db.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions internal/endtoend/testdata/alias_join/postgresql/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

88 changes: 88 additions & 0 deletions internal/endtoend/testdata/alias_join/postgresql/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions internal/endtoend/testdata/alias_join/postgresql/query.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
-- name: RetrieveAllWithDeprecation :many
select
arn,
name,
aws_rds_databases.engine
from
aws_rds_databases r
natural join aws_rds_databases_engines
;

-- name: RetrieveAllWithDeprecationOther :many
select
arn,
name,
r.engine
from
aws_rds_databases r
natural join aws_rds_databases_engines
;
Loading
Loading