Skip to content

feat: add C implementation for math/base/special/bessely1 #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

feat: add C implementation for math/base/special/bessely1 #4396

wants to merge 19 commits into from

Conversation

ShabiShett07
Copy link
Contributor

@ShabiShett07 ShabiShett07 commented Dec 30, 2024 •
edited
Loading

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
Open to reviews!!

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 30, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 30, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/bessely1 $\color{red}455/463$
$\color{green}+98.27\%$ 		$\color{red}39/45$
$\color{green}+86.67\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{red}455/463$
$\color{green}+98.27\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 30, 2024
@kgryte kgryte changed the title feat: add math/base/special/bessely1 feat: add C implementation math/base/special/bessely1 Dec 30, 2024
@ShabiShett07
Copy link
Contributor Author

Errors have been fixed

@ShabiShett07
Copy link
Contributor Author

/stdlib check-files

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 2, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@ShabiShett07
Fixed package.json
525a293 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

I have fixed the errors in package.json

@ShabiShett07 ShabiShett07 changed the title feat: add C implementation math/base/special/bessely1 feat: add math/base/special/bessely1 Jan 6, 2025
@ShabiShett07
Copy link
Contributor Author

@Neerajpathak07, need your assistance in this!

@Neerajpathak07
Copy link
Contributor

Neerajpathak07 commented Feb 22, 2025 •
edited
Loading

@ShabiShett07 few changes and some additional points:-

  • Were the rational functions automatically generated upon running the the corresponding JS file if yes then there's no reason to worry.
  • Since this PR aimed at adding C implementation for the existing JS implementation change the PR tittle to:-
    feat: add C implementation for math/base/special/bessely1

@ShabiShett07
Copy link
Contributor Author

@Neerajpathak07, made all necessary changes as per your suggestion, is there any other errors I need to fix?

@kgryte kgryte requested a review from gunjjoshi February 22, 2025 21:10
@kgryte kgryte added the C Issue involves or relates to C. label Feb 22, 2025
@gunjjoshi
Copy link
Member

@ShabiShett07 You'll have to update evalrational.js, and then run it to generate the rational functions, rather than copying and pasting them in main.js. You can refer: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/bessely0/scripts/evalrational.js

gunjjoshi
gunjjoshi requested changes Feb 23, 2025
View reviewed changes
@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 23, 2025
@ShabiShett07
fix: update README.md
41d94f9 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: update benchmark.native.js
dffa637 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: update benchmark.js
5539f34 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: update main.c
b80da73 
Signed-off-by: Shabareesh Shetty <[email protected]>
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 28, 2025
@ShabiShett07
Copy link
Contributor Author

Hey, @gunjjoshi sir, Thank you for reviewing and I have tried to solve the errors which you have have pointed out, please do check

@ShabiShett07
Merge branch 'develop' into feature/bessely1
8e41446 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: update benchmark.js
e73daee 
Signed-off-by: Shabareesh Shetty <[email protected]>
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@Planeshifter
Copy link
Member

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged.

Required action:
Use "Progresses:" or "Ref:" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@stdlib-bot stdlib-bot removed the Potential Duplicate There might be another pull request resolving the same issue. label Apr 19, 2025
ShabiShett07 and others added 6 commits April 23, 2025 11:52
@ShabiShett07
feat: add /blas/base/zrotg
a5470f7
@stdlib-bot @ShabiShett07
chore: update copyright years
24c63df
@ShabiShett07
docs: add files
134d5a7 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot @ShabiShett07
chore: update copyright years
503db28
@ShabiShett07
chore: update implementation
5ab7572 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
remove: unnnecessary files
bcb2fe6 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

@gunjjoshi gunjjoshi Awaiting requested review from gunjjoshi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShabiShett07 @stdlib-bot @Neerajpathak07 @gunjjoshi @Planeshifter @kgryte