-
-
Notifications
You must be signed in to change notification settings - Fork 804
chore: address commit comments in README, benchmark, and main.c #5763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address commit comments in README, benchmark, and main.c #5763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Signed-off-by: Abhay Punia <[email protected]>
Signed-off-by: Abhay Punia <[email protected]>
…5/stdlib into fix-stdlib-bot-comments
Signed-off-by: Abhay Punia <[email protected]>
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Left comments on what needs to change for this to land.
Hi, @Planeshifter
|
lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/normal/quantile/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #5712
Description
This pull request:
1f5d85a
) #5712.Related Issues
This pull request:
1f5d85a
) #5712Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers