Skip to content

style: fix lint errors #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

hemantmm
Copy link
Contributor

@hemantmm hemantmm commented Mar 3, 2025

Resolves #5453

Description

What is the purpose of this pull request?

This pull request:

  • Fix EditorConfig lint errors by removing tabs and adding spaces

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: hemantmm <[email protected]>
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 3, 2025
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 3, 2025

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/assert/is-allowed-data-type-cast $\color{green}116/116$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}116/116$
$\color{green}+100.00\%$
ndarray/safe-casts $\color{green}175/175$
$\color{green}+100.00\%$
$\color{green}16/16$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}175/175$
$\color{green}+100.00\%$
number/float64/base/signbit $\color{green}169/169$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}169/169$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@hemantmm
Copy link
Contributor Author

hemantmm commented Mar 3, 2025

@kgryte have a look at this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files now mix tabs and spaces for indentation. That's not desired.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 4, 2025
@hemantmm hemantmm requested a review from Planeshifter March 4, 2025 05:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 4, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest.json file still mixes tabs and spaces. We also want 2-space indentation.

Provided you have EditorConfig setup, say via an extension in your code editor, then just saving these files should format them correctly.

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 6, 2025
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@kgryte kgryte added Duplicate This issue or pull request already exists. autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. labels Apr 2, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Duplicate This issue or pull request already exists. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
4 participants