Skip to content

feat: add protocol support to stats/base/range #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
38 changes: 15 additions & 23 deletions lib/node_modules/@stdlib/stats/base/range/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ The [**range**][range] is defined as the difference between the maximum and mini
var range = require( '@stdlib/stats/base/range' );
```

#### range( N, x, stride )
#### range( N, x, strideX )

Computes the [range][range] of a strided array `x`.

Expand All @@ -54,17 +54,14 @@ The function has the following parameters:

- **N**: number of indexed elements.
- **x**: input [`Array`][mdn-array] or [`typed array`][mdn-typed-array].
- **stride**: index increment for `x`.
- **strideX**: stride length for `x`.

The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to compute the [range][range] of every other element in `x`,
The `N` and `stride` parameters determine which elements in the strided array are accessed at runtime. For example, to compute the [range][range] of every other element in `x`,

```javascript
var floor = require( '@stdlib/math/base/special/floor' );

var x = [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ];
var N = floor( x.length / 2 );

var v = range( N, x, 2 );
var v = range( 4, x, 2 );
// returns 6.0
```

Expand All @@ -74,18 +71,15 @@ Note that indexing is relative to the first index. To introduce an offset, use [

```javascript
var Float64Array = require( '@stdlib/array/float64' );
var floor = require( '@stdlib/math/base/special/floor' );

var x0 = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element

var N = floor( x0.length / 2 );

var v = range( N, x1, 2 );
var v = range( 4, x1, 2 );
// returns 6.0
```

#### range.ndarray( N, x, stride, offset )
#### range.ndarray( N, x, strideX, offsetX )

Computes the [range][range] of a strided array using alternative indexing semantics.

Expand All @@ -99,17 +93,14 @@ var v = range.ndarray( N, x, 1, 0 );

The function has the following additional parameters:

- **offset**: starting index for `x`.
- **offsetX**: starting index for `x`.

While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to calculate the [range][range] for every other value in `x` starting from the second value
While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the [range][range] for every other value in `x` starting from the second value

```javascript
var floor = require( '@stdlib/math/base/special/floor' );

var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ];
var N = floor( x.length / 2 );

var v = range.ndarray( N, x, 2, 1 );
var v = range.ndarray( 4, x, 2, 1 );
// returns 6.0
```

Expand All @@ -123,6 +114,7 @@ var v = range.ndarray( N, x, 2, 1 );

- If `N <= 0`, both functions return `NaN`.
- Depending on the environment, the typed versions ([`drange`][@stdlib/stats/base/drange], [`srange`][@stdlib/stats/base/srange], etc.) are likely to be significantly more performant.
- Both functions support array-like objects having getter and setter accessors for array element access (e.g., [`@stdlib/array/base/accessor`][@stdlib/array/base/accessor]).

</section>

Expand All @@ -137,16 +129,14 @@ var v = range.ndarray( N, x, 2, 1 );
```javascript
var randu = require( '@stdlib/random/base/randu' );
var round = require( '@stdlib/math/base/special/round' );
var Float64Array = require( '@stdlib/array/float64' );
var linspace = require( '@stdlib/array/base/linspace' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use @stdlib/random/array/discrete-uniform.

var range = require( '@stdlib/stats/base/range' );

var x;
var i;

x = new Float64Array( 10 );
for ( i = 0; i < x.length; i++ ) {
x[ i ] = round( (randu()*100.0) - 50.0 );
}
x = linspace(-50, 50, 10);
x = x.map(round);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will then become

Suggested change
x = linspace(-50, 50, 10);
x = x.map(round);
x = discreteUniform( 10, -50, 50, {
'dtype': 'float64'
});

console.log( x );

var v = range( x.length, x, 1 );
Expand Down Expand Up @@ -185,6 +175,8 @@ console.log( v );

[mdn-typed-array]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray

[@stdlib/array/base/accessor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/array/base/accessor

<!-- <related-links> -->

[@stdlib/stats/base/drange]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/drange
Expand Down
10 changes: 2 additions & 8 deletions lib/node_modules/@stdlib/stats/base/range/benchmark/benchmark.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var linspace = require( '@stdlib/array/base/linspace' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use @stdlib/random/array/uniform, rather than linspace.

var pow = require( '@stdlib/math/base/special/pow' );
var pkg = require( './../package.json' ).name;
var range = require( './../lib/range.js' );
Expand All @@ -38,13 +38,7 @@ var range = require( './../lib/range.js' );
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var x;
var i;

x = [];
for ( i = 0; i < len; i++ ) {
x.push( ( randu()*20.0 ) - 10.0 );
}
var x = linspace( 0.0, len, len );
return benchmark;

function benchmark( b ) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var linspace = require( '@stdlib/array/linspace' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment.

var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var pkg = require( './../package.json' ).name;
Expand All @@ -39,12 +40,7 @@ var range = require( './../lib/ndarray.js' );
*/
function createBenchmark( len ) {
var x;
var i;

x = [];
for ( i = 0; i < len; i++ ) {
x.push( ( randu()*20.0 ) - 10.0 );
}
var x = linspace( 0.0, len, len );
return benchmark;

function benchmark( b ) {
Expand Down
74 changes: 53 additions & 21 deletions lib/node_modules/@stdlib/stats/base/range/docs/repl.txt
Original file line number Diff line number Diff line change
@@ -1,92 +1,124 @@
{{alias}}( N, x, strideX )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{alias}}( N, x, strideX )
{{alias}}( N, x, strideX )



{{alias}}( N, x, stride )
Computes the range of a strided array.

The `N` and `stride` parameters determine which elements in `x` are accessed
at runtime.

Indexing is relative to the first index. To introduce an offset, use a typed
array view.
The `N` and stride parameters determine which elements in the strided
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look properly wrapped at 80 chars.

array are accessed at runtime.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Indexing is relative to the first index. To introduce an offset, use a
typed array view.


If `N <= 0`, the function returns `NaN`.


Parameters
----------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding all these blank lines? Please remove and follow our REPL text style guide.


N: integer
Number of indexed elements.


x: Array<number>|TypedArray
Input array.

stride: integer
Index increment.

strideX: integer
Stride length.


Returns
-------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?


out: number
Range.


Examples
--------


// Standard Usage:
> var x = [ 1.0, -2.0, 2.0 ];
> {{alias}}( x.length, x, 1 )
4.0

// Using `N` and `stride` parameters:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to go through and remove all these stray lines. Please study other repl.txt files.

// Using `N` and stride parameters:
> x = [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ];
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
> var stride = 2;
> {{alias}}( N, x, stride )
> {{alias}}( 3, x, stride )
4.0


// Using view offsets:
> var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] );
> var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );
> N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 );
> stride = 2;
> {{alias}}( N, x1, stride )
> {{alias}}( 3, x1, stride )
4.0

{{alias}}.ndarray( N, x, stride, offset )
Computes the range of a strided array using alternative indexing semantics.

{{alias}}.ndarray( N, x, strideX, offsetX )


Computes the range of a strided array using alternative indexing
semantics.


While typed array views mandate a view offset based on the underlying
buffer, the `offset` parameter supports indexing semantics based on a
starting index.


Parameters
----------


N: integer
Number of indexed elements.


x: Array<number>|TypedArray
Input array.

stride: integer
Index increment.

offset: integer
strideX: integer
Stride length.


offsetX: integer
Starting index.


Returns
-------


out: number
Range.


Examples
--------


// Standard Usage:
> var x = [ 1.0, -2.0, 2.0 ];
> {{alias}}.ndarray( x.length, x, 1, 0 )
4.0


// Using offset parameter:
> var x = [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ];
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
> {{alias}}.ndarray( N, x, 2, 1 )
> {{alias}}.ndarray( 3, x, 2, 1 )
4.0

See Also
--------

See Also
--------
16 changes: 9 additions & 7 deletions lib/node_modules/@stdlib/stats/base/range/docs/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,20 @@

/// <reference types="@stdlib/types"/>

import { NumericArray } from '@stdlib/types/array';
import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array';

/**
* Interface describing `range`.
*/
type InputArray = NumericArray | Collection<number> | AccessorArrayLike<number>;

interface Routine {
/**
* Computes the range of a strided array.
*
* @param N - number of indexed elements
* @param x - input array
* @param stride - stride length
* @param strideX - stride length
* @returns range
*
* @example
Expand All @@ -40,15 +42,15 @@ interface Routine {
* var v = range( x.length, x, 1 );
* // returns 4.0
*/
( N: number, x: NumericArray, stride: number ): number;
( N: number, x: InputArray, strideX: number ): number;

/**
* Computes the range of a strided array using alternative indexing semantics.
*
* @param N - number of indexed elements
* @param x - input array
* @param stride - stride length
* @param offset - starting index
* @param strideX - stride length
* @param offsetX - starting index
* @returns range
*
* @example
Expand All @@ -57,15 +59,15 @@ interface Routine {
* var v = range.ndarray( x.length, x, 1, 0 );
* // returns 4.0
*/
ndarray( N: number, x: NumericArray, stride: number, offset: number ): number;
ndarray( N: number, x: InputArray, strideX: number, offsetX: number ): number;
}

/**
* Computes the range of a strided array.
*
* @param N - number of indexed elements
* @param x - input array
* @param stride - stride length
* @param strideX - stride length
* @returns range
*
* @example
Expand Down
3 changes: 3 additions & 0 deletions lib/node_modules/@stdlib/stats/base/range/docs/types/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* limitations under the License.
*/

import AccessorArray = require( '@stdlib/array/base/accessor' );
import range = require( './index' );


Expand All @@ -26,6 +27,7 @@ import range = require( './index' );
const x = new Float64Array( 10 );

range( x.length, x, 1 ); // $ExpectType number
range( x.length, new AccessorArray( x ), 1 ); // $ExpectType number
}

// The compiler throws an error if the function is provided a first argument which is not a number...
Expand Down Expand Up @@ -85,6 +87,7 @@ import range = require( './index' );
const x = new Float64Array( 10 );

range.ndarray( x.length, x, 1, 0 ); // $ExpectType number
range.ndarray( x.length, new AccessorArray( x ), 1, 0 ); // $ExpectType number
}

// The compiler throws an error if the `ndarray` method is provided a first argument which is not a number...
Expand Down
Loading
Loading