-
-
Notifications
You must be signed in to change notification settings - Fork 806
feat: add stats/array/range
#6706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
@gururaj1512 Looks like you omitted accessor array tests in this PR. I am guessing that you did this because Looks like there is a PR open adding such support, but it may need further clean-up to get over the finish line: #5779 |
|
||
## Notes | ||
|
||
- If provided an empty array, the function returns `NaN`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also omitted the accessor note, which is present in stats/array/max
. That will need to be added once stats/base/range
has accessor support.
/** | ||
* Input array. | ||
*/ | ||
type InputArray = NumericArray | Collection<number>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing AccessorArrayLike<number>
due to stats/base/range
.
{ | ||
const x = new Float64Array( 10 ); | ||
|
||
range( x ); // $ExpectType number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need accessor array tests.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves None
Description
This pull request:
stats/array/range
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers